#12919: Typo in Parent.discover_action
-------------------------------------+--------------------------------------
Reporter: nthiery | Owner: robertwb
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: coercion | Resolution:
Keywords: days38 | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nicolas M. Thiéry | Merged in:
Dependencies: | Stopgaps:
-------------------------------------+--------------------------------------
Description changed by nthiery:
Old description:
> This patch fixes an obvious typo in discover_action. Alas, it's in a
> seldom used branch, and I could not extract a suitable regression test (I
> stumbled on the issue with a large coercion graph using quite some
> experimental code). And even then, the regression would not necessarily
> robustly catch the broken branch.
>
> If someone wants to play further, here is the kind of thing I tried:
> {{{
> class P(Parent):
> def __init__(self):
> Parent.__init__(self, category=Sets())
> Element=ElementWrapper
> A = P(); a = A("a")
> B = P(); b = A("b")
> C = P(); c = A("c")
> D = P(); d = A("d")
> Hom(A,B)(lambda x: b).register_as_coercion()
> Hom(B,C)(lambda x: c).register_as_coercion()
> Hom(C,D)(lambda x: d).register_as_coercion()
> Hom(D,A)(lambda x: a).register_as_coercion()
> }}}
>
> But I guess it could go as is
New description:
This patch fixes an obvious typo in discover_action. Alas, it's in a
seldom used branch, and I could not extract a suitable regression test (I
stumbled on the issue with a large coercion graph using quite some
experimental code). And even then, the regression would not necessarily
robustly catch the broken branch.
If someone wants to play further, here is the kind of thing I
(unsuccessfully) tried:
{{{
class P(Parent):
def __init__(self):
Parent.__init__(self, category=Sets())
Element=ElementWrapper
A = P(); a = A("a")
B = P(); b = A("b")
C = P(); c = A("c")
D = P(); d = A("d")
Hom(A,B)(lambda x: b).register_as_coercion()
Hom(B,C)(lambda x: c).register_as_coercion()
Hom(C,D)(lambda x: d).register_as_coercion()
Hom(D,A)(lambda x: a).register_as_coercion()
}}}
But I guess this patch is obvious enough to could go as is
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12919#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
