#11563: Make lrcalc a standard package
-------------------------------------------------------+--------------------
Reporter: nthiery | Owner:
sage-combinat
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-5.1
Component: combinatorics | Resolution:
Keywords: lrcalc, symmetric functions, days38 | Work issues:
Report Upstream: N/A | Reviewers: Anne
Schilling, Jeroen Demeyer
Authors: Nicolas M. Thiéry | Merged in:
Dependencies: #10333 | Stopgaps:
-------------------------------------------------------+--------------------
Changes (by nthiery):
* status: needs_work => needs_review
Comment:
Replying to [comment:10 jdemeyer]:
> You should use `$MAKE` instead of `make` in `spkg-install` and `spkg-
check`.
>
> Some of the files in the spkg are not world-readable. Please fix this
with
> {{{
> chmod ugo+rX -R src
> }}}
Thanks for catching those. Done. Anne: may I let you set the final
positive review? Here is the diff in the updated version I am about to
upload (sorry, it does not show up permission changes):
{{{
diff --git a/spkg-check b/spkg-check
--- a/spkg-check
+++ b/spkg-check
@@ -8,7 +8,7 @@ fi
cd src
-make check
+$MAKE check
if [ $? -ne 0 ]; then
echo "Error testing lrcalc."
exit 1
diff --git a/spkg-install b/spkg-install
--- a/spkg-install
+++ b/spkg-install
@@ -14,13 +14,13 @@ if [ $? -ne 0 ]; then
exit 1
fi
-make
+$MAKE
if [ $? -ne 0 ]; then
echo "Error building lrcalc."
exit 1
fi
-make install
+$MAKE install
if [ $? -ne 0 ]; then
echo "Error installing lrcalc."
exit 1
}}}
> The `SAGE_ROOT` patch [attachment:trac_11563-lrcalc-sageroot-nt.patch]
gets positive_review from me.
Thanks.
> Finally: adding a new '''standard''' package should always be discussed
on the sage-devel mailing list.
We did it a long time ago :-)
http://groups.google.com/group/sage-
devel/browse_thread/thread/2e7114375f6f88a5/ca4e2ecb49fcc1cd?lnk=gst&q=lrcalc#ca4e2ecb49fcc1cd
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11563#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
