#12971: Biggs-Smith graph
------------------------------------------+---------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: graph theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nathann Cohen | Merged in:
Dependencies: #12942, #12945, #12952 | Stopgaps:
------------------------------------------+---------------------------------
Comment (by kini):
OK!! Time to review! :) I've made a reviewer patch, which I will attach
after I make this comment. Besides the usual reformatting, I also removed
a comma from the exception message, and changed the name of the function
from `BiggsSmith()` to `BiggsSmithGraph()`. I guess I don't have a strong
opinion about which name is better, but if you use `BiggsSmith()` then we
should change all the other graph names for consistency, and that is
infeasible, so for now, let's just keep it as `BiggsSmithGraph()`.
If you agree with my review patch, then we can change it to positive
review. :)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12971#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
