#12982: McGeeGraph, Tutte12Cage, TutteCoxeterGraph, WagnerGraph
------------------------------------------------------------------+---------
Reporter: ncohen |
Owner: jason, ncohen, rlm
Type: enhancement |
Status: needs_review
Priority: major |
Milestone: sage-5.1
Component: graph theory |
Resolution:
Keywords: sd40.5 | Work
issues:
Report Upstream: N/A |
Reviewers: Keshav Kini
Authors: Nathann Cohen | Merged
in:
Dependencies: #12942, #12945, #12952, #12971, #12980, #12981 |
Stopgaps:
------------------------------------------------------------------+---------
Changes (by kini):
* keywords: => sd40.5
* reviewer: => Keshav Kini
Comment:
Another review patch for you! This time your patch needed to be rebased on
my earlier review patches too...
Other than reformatting, I changed some doctests which seem to be copied
and pasted from earlier graphs you made - they are retesting the default
value of `embedding`, when they should be testing the non-default one. I
also reused a previously generated graph instead of regenerating it, in
line 4642 of `graph_generators.py`.
If you agree with the review patch, we can set the ticket to positive
review.
patchbot: apply trac_12982.rebased.patch trac_12982.reviewer.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12982#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
