#12767: Clean up dead links in sage/rings/number_field documentation
----------------------------------+-----------------------------------------
Reporter: davidloeffler | Owner: davidloeffler
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: number fields | Resolution:
Keywords: sd40.5 | Work issues:
Report Upstream: N/A | Reviewers: Karl-Dieter Crisman
Authors: David Loeffler | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by kcrisman):
* keywords: => sd40.5
* reviewer: => Karl-Dieter Crisman
Comment:
Comments:
* I can't give the new code itself positive review, although it seems
correct (mostly I have questions about the change to `absolute_degree`.
Maybe that could be moved to a different ticket if one doesn't find a
reviewer?
* I can, however, suggest a trivial fix - the second-to-last line below
had `new_codomain`, not `new_domain` (I'd add a patch, but see the
previous comment):
{{{
def extend_domain(self, new_domain):
r"""
INPUT:
- ``self`` -- a member of Hom(Y, Z)
- ``new_domain`` -- an object X such that there is a canonical
coercion
`\phi` in Hom(X, Y)
}}}
Also, maybe we want to just turn that double-underscore attribute into a
single-underscore attribute? Here at SD 40.5 that is being suggested
strongly for any occurrences of such things.
* In the nearly identical two occurrences of
{{{
self.__maximal_order[v] = RelativeOrder(self, abs_order, is_maximal=True,
check=False)
}}}
is it possible that the first one is not supposed to have the `[v]`?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12767#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
