#6812: Enumerate integer vectors modulo to the action of a Permutation Group
------------------------------------------------------------------+---------
       Reporter:  nborie                                          |         
Owner:  nborie                                                  
           Type:  enhancement                                     |        
Status:  needs_review                                            
       Priority:  major                                           |     
Milestone:  sage-5.1                                                
      Component:  combinatorics                                   |    
Resolution:                                                          
       Keywords:  enumeration, integer, list, permutation, group  |   Work 
issues:  long time tests, information about listing infinite sets
Report Upstream:  N/A                                             |     
Reviewers:  Karl-Dieter Crisman, Simon King                         
        Authors:  Nicolas Borie                                   |     Merged 
in:                                                          
   Dependencies:                                                  |      
Stopgaps:                                                          
------------------------------------------------------------------+---------

Comment (by SimonKing):

 In the function lex_cmp_partial, I see that the `__getitem__` method of
 clonable int arrays is called repeatedly. Calling `__getitem__` means: It
 is tested whether the argument is an integer or a slice, and whether the
 integer is non-negative and smaller than the length of the array.

 I would think that lex_cmp_partial is called very often and is thus time
 critical, isn't it? Then, one should be a bit more direct: One should test
 saneness of the argument "`step`" only once, and should then directly
 access `v1._list[i]` and `v2._list[i]`. After all, v1 and v2 already are
 cdefined.

 I suppose the corresponding change will be part of my reviewer patch, but
 I'd appreciate if Nicolas would send me a couple of examples, so that I
 can see whether there is a speed-up.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6812#comment:72>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to