#12993: Bug in computing the rank function a poset
--------------------------------------------------+-------------------------
       Reporter:  saliola                         |         Owner:  
sage-combinat
           Type:  defect                          |        Status:  
needs_review 
       Priority:  major                           |     Milestone:  sage-5.1    
 
      Component:  combinatorics                   |    Resolution:              
 
       Keywords:  poset, combinat                 |   Work issues:              
 
Report Upstream:  N/A                             |     Reviewers:              
 
        Authors:  Darij Grinberg, Anne Schilling  |     Merged in:              
 
   Dependencies:                                  |      Stopgaps:              
 
--------------------------------------------------+-------------------------

Comment (by saliola):

 Here is a review patch. Apply on top of Christian's review patch (which
 goes on top of Anne's).

 It looks at each edge exactly twice.

 I also updated the documentation for Poset.rank_function.

 Christian: I see you didn't run the doctests. I had to fix your attempt at
 using rank_function for plotting.

 Also, there is a pickling error that got introduced by your patch in
 posets.py, but I can't replicated it from within Sage. I don't have time
 to debug this now, so go ahead and try to sort it out.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12993#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to