#12761: Givaro's (3.2.13.rc1) C++ headers don't conform to C++11
--------------------------------------------------------------+-------------
Reporter: leif | Owner:
leif
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-5.1
Component: packages | Resolution:
Keywords: C++11 GCC 4.7.0 CXXFLAGS -fpermissive spkg | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Leif Leonhardy, Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
--------------------------------------------------------------+-------------
Changes (by {'newvalue': u'Leif Leonhardy, Jeroen Demeyer', 'oldvalue': u'Leif
Leonhardy'}):
* author: Leif Leonhardy => Leif Leonhardy, Jeroen Demeyer
Old description:
> This breaks the build of its test suite as well as of the Sage library
> '''with''' (e.g.) '''GCC 4.7.x'''.
>
> I already have an spkg fixing this, i.e., the offending headers.
>
> See #12751 for the GCC-4.7.0 metaticket.
>
> Closely related: #12444 (which I unfortunately wasn't aware of until now)
> for the `clang` port
>
> ----
>
> '''New spkg:'''
> [http://boxen.math.washington.edu/home/leif/Sage/spkgs/givaro-3.2.13.rc1.p4.spkg]
>
> '''md5sum:''' `a84996518e39a1197eaf63562d8fe734
> givaro-3.2.13.rc1.p4.spkg`
>
> === givaro-3.2.13.rc1.p4 (Leif Leonhardy, March 27th 2012) ===
> * #12761: Fix headers not conforming to C++11 to make Sage (especially
> the
> Sage library) build with GCC 4.7.0 (and without `-fpermissive`).
> Same for Givaro's test suite, which uses / instantiates much more!
> (These headers get installed into `$SAGE_LOCAL/include/givaro/`.)
> New patches:
> - patches/src.kernel.integer.givintnumtheo.inl.patch
> - patches/src.kernel.integer.givintrsa.inl.patch
> - patches/src.library.poly1.givpoly1factor.inl.patch
> - patches/src.library.poly1.givpoly1padic.h.patch
> - patches/src.library.poly1.givpoly1proot.inl.patch
> * Remove the obsolete Debian `dist/` directory.
> * Remove obsolete GCC 4.3 patch.
> * Rename diffs of prepatched files that are (still) copied over to
> `*.diff`
> (rather than `*.patch`) such that they don't get "automatically"
> applied
> by the `patch -p1` loop, which I added.
> * Fix permissions of `SPKG.txt` and `spkg-install`, and two upstream
> files.
> * Add "Special Update/Build Instructions" section.
> * Clean up `spkg-check` and `spkg-install`.
> * Also set up environment variables in `spkg-check`, as `make check`
> involves
> compilation. (Although `configure` should have put them into the
> generated
> Makefiles.)
> * Use `$MAKE` in `spkg-check` as well.
> * Exit in case the build failed!
> * Only `touch` extension modules (`*.pyx`) if they (already) exist.
New description:
This breaks the build of its test suite as well as of the Sage library
'''with''' (e.g.) '''GCC 4.7.x'''.
I already have an spkg fixing this, i.e., the offending headers.
See #12751 for the GCC-4.7.0 metaticket.
Closely related: #12444 (which I unfortunately wasn't aware of until now)
for the `clang` port
----
'''New spkg:'''
[http://boxen.math.washington.edu/home/jdemeyer/spkg/givaro-3.2.13.p0.spkg]
=== givaro-3.2.13.p0 (Jeroen Demeyer, 25 May 2012) ===
* #12761: Restore upstream sources to vanilla 3.2.13 (the previous
src/ directory was some never-released CVS version between
givaro-3.2.13.rc1 and givaro-3.2.13, but bootstrapped with a
different automake).
* Remove gmp++.h.patch which is upstreamed (the old diff was wrong).
* Use `patch` to apply all patches.
* Fix patch for givtablelimits.h such that it can be applied on all
systems, not only Cygwin.
* Merged all GCC-4.7.0 patches into one: cplusplus_scoping.patch
* Don't touch .pyx files, instead fix module_list.py (also on #12761).
=== givaro-3.2.13.rc1.p4 (Leif Leonhardy, March 27th 2012) ===
* #12761: Fix headers not conforming to C++11 to make Sage (especially
the
Sage library) build with GCC 4.7.0 (and without `-fpermissive`).
Same for Givaro's test suite, which uses / instantiates much more!
(These headers get installed into `$SAGE_LOCAL/include/givaro/`.)
New patches:
- patches/src.kernel.integer.givintnumtheo.inl.patch
- patches/src.kernel.integer.givintrsa.inl.patch
- patches/src.library.poly1.givpoly1factor.inl.patch
- patches/src.library.poly1.givpoly1padic.h.patch
- patches/src.library.poly1.givpoly1proot.inl.patch
* Remove the obsolete Debian `dist/` directory.
* Remove obsolete GCC 4.3 patch.
* Rename diffs of prepatched files that are (still) copied over to
`*.diff`
(rather than `*.patch`) such that they don't get "automatically"
applied
by the `patch -p1` loop, which I added.
* Fix permissions of `SPKG.txt` and `spkg-install`, and two upstream
files.
* Add "Special Update/Build Instructions" section.
* Clean up `spkg-check` and `spkg-install`.
* Also set up environment variables in `spkg-check`, as `make check`
involves
compilation. (Although `configure` should have put them into the
generated
Makefiles.)
* Use `$MAKE` in `spkg-check` as well.
* Exit in case the build failed!
* Only `touch` extension modules (`*.pyx`) if they (already) exist.
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12761#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
