#13018: Positive definite check for exact matrices
----------------------------------+-----------------------------------------
       Reporter:  rbeezer         |         Owner:  jason, was  
           Type:  enhancement     |        Status:  needs_review
       Priority:  minor           |     Milestone:  sage-5.1    
      Component:  linear algebra  |    Resolution:              
       Keywords:  sd40.5          |   Work issues:              
Report Upstream:  N/A             |     Reviewers:  Dan Drake   
        Authors:  Rob Beezer      |     Merged in:              
   Dependencies:  #12966          |      Stopgaps:              
----------------------------------+-----------------------------------------
Changes (by {'newvalue': u'Rob Beezer', 'oldvalue': u'Rob beezer'}):

  * reviewer:  => Dan Drake
  * author:  Rob beezer => Rob Beezer


Comment:

 This looks good. Several comments:

 * Minor grammar error: "This routine will return ``True`` if the matrix is
 square, symmetric or Hermitian, and meeting the condition..." should be
 "and ''meets'' the condition...".

 * for the matrices that aren't positive definite, maybe you can include a
 doctest that has a vector for which `v^T * M * v` is negative.

 * for the matrices that ''are'' pos. def., maybe create a random vector in
 the base ring and see if you get something positive. I'm thinking:
 {{{
 sage: v = vector([C.random_element(), C.random_element(),
 C.random_element(), C.random_element()])
 sage: v.conjugate() * A * v > 0
 True
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13018#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to