#12892: Toric fibration morphisms
--------------------------------------+-------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: algebraic geometry | Resolution:
Keywords: sd40.5 | Work issues:
Report Upstream: N/A | Reviewers: Andrey Novoseltsev
Authors: Volker Braun | Merged in:
Dependencies: #12361 | Stopgaps:
--------------------------------------+-------------------------------------
Comment (by novoselt):
For the second patch:
1. `relative_star_generators` does not have INPUT/OUTPUT and in general
it would be nice to have a clear description of what it does.
2. Can we please rename `fiber` to `generic_fiber`? (I would expect that
`fiber` would return a particular one based on some input.) Also - why the
documentation says that it returns a connected component, isn't it unique
for a generic fiber?
3. I also got confused by `fiber_component` name thinking it computes the
fiber over points corresponding to higher-dimensional cones of the
codomain. After some more thinking and reading I think that it is indeed
the correct name, but would be nice to describe in the documentation the
structure of non-generic fibers and why it makes more sense to work with
components corresponding to domain cones rather than fibers of codomain
ones.
4. `fiber_component` and `fiber_dimension` also lack INPUT/OUTPUT blocks.
5. `SchemeMorphism_fan_fiber_toric_variety` input documentation does not
match the code.
6. Perhaps the name of the class can be changed to
`..._fiber_component_...` since it does not operate with the whole fiber.
7. "Defined by embedding the fiber irreducible component defined by the
primitive preimage cone 1-d cone of Rational polyhedral fan in 4-d lattice
N." does not read. While I was trying to reformulate it, I became unsure
of this class at all. Isn't it just about embedding a torus orbit closure
into the original toric variety? I.e. the toric morphism and fibers are
not important?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12892#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
