#12671: attaching files which have spaces in absolute path name fails on second
run
------------------------------------------------+---------------------------
Reporter: ppurka | Owner: jason
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.1
Component: misc | Resolution:
Keywords: attach load preparser sd40.5 | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Punarbasu Purkayastha | Merged in:
Dependencies: | Stopgaps:
------------------------------------------------+---------------------------
Changes (by ddrake):
* status: positive_review => needs_work
Comment:
I strongly disagree with the positive review. The existing code is totally
crazy -- it distinguishes between strings with and without spaces by
running `eval()` on them and catching an exception. The patch here does
not fix this; it only distinguishes between "a string possibly with spaces
that represents a filename" and "a space-separated list of filenames, none
of which have spaces".
Keshav Kini and I discussed this and agree that the current design is
extremely poor. I am almost done with a simple patch that vastly improves
the function.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12671#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
