#11888: Sage is missing the lambert_w function
-----------------------------------------------------------------------+----
Reporter: benjaminfjones |
Owner: burcin
Type: defect |
Status: needs_work
Priority: minor |
Milestone: sage-5.1
Component: symbolics |
Resolution:
Keywords: lambert_w symbolics conversion maxima sd35.5 sd40.5 | Work
issues:
Report Upstream: N/A |
Reviewers: Keshav Kini, Karl-Dieter Crisman, Fredrik Johansson, Burcin Erocal,
Douglas McNeil, William Stein
Authors: Benjamin Jones |
Merged in:
Dependencies: |
Stopgaps:
-----------------------------------------------------------------------+----
Changes (by was):
* status: positive_review => needs_work
* reviewer: Keshav Kini, Karl-Dieter Crisman, Fredrik Johansson, Burcin
Erocal, Douglas McNeil => Keshav Kini, Karl-
Dieter Crisman, Fredrik Johansson, Burcin
Erocal, Douglas McNeil, William Stein
Comment:
This patch is awesome! It's also a great example of how to make a well-
documented new symbolic function that illustrates many issues. Here are a
few trivial nitpicks:
* What is "simplication"?
{{{
When automatic simplication occurs, the parent of the output value should
be
}}}
* This docstring should start with r" since it contains a backslash:
{{{
646 """
647 The derivative of `W_n(x)` is `W_n(x)/(x \cdot
W_n(x) + x)`.
}}}
(check for similar instances throughout).
* Don't use periods at the end of exceptions (also don't capitalize).
Many instances of this being wrong, e.g.,
{{{
679 raise ValueError("Derivative not defined with
respect to the branch number.")
}}}
Here's a good example of what an exception string should look like (built
into python):
{{{
>>> 1/0
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ZeroDivisionError: integer division or modulo by zero
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11888#comment:61>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
