#748: [waiting on upstream] update iml to the 1.0.3 release + our patches
------------------------------------+---------------------------------------
Reporter: was | Owner: mabshoff
Type: defect | Status: new
Priority: major | Milestone:
sage-duplicate/invalid/wontfix
Component: packages | Resolution:
Keywords: spkg upgrade iml | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
------------------------------------+---------------------------------------
Comment (by kini):
Thanks, that will help. We cannot run autotools at build time, only at
packaging time, since we don't have autotools as a dependency of Sage, nor
do we package it in Sage. So rather than including your patch I guess I
should apply it, run autotools, and then save *that* diff as a patch to
apply at build time.
Before seeing your diff I had solved the repl problem like this:
{{{#!diff
diff --git a/repl/Makefile.am b/repl/Makefile.am
index 4cf001b..7be2e86 100644
--- a/repl/Makefile.am
+++ b/repl/Makefile.am
@@ -1,4 +1,4 @@
noinst_LTLIBRARIES = librepl.la
-librepl_la_SOURCES =
+librepl_la_SOURCES = dummy.c
librepl_la_LIBADD = @LTLIBOBJS@
diff --git a/repl/Makefile.in b/repl/Makefile.in
index 5c65bfa..ba963ec 100644
--- a/repl/Makefile.in
+++ b/repl/Makefile.in
@@ -51,7 +51,7 @@ CONFIG_HEADER = $(top_builddir)/config.h
CONFIG_CLEAN_FILES =
LTLIBRARIES = $(noinst_LTLIBRARIES)
librepl_la_DEPENDENCIES = @LTLIBOBJS@
-am_librepl_la_OBJECTS =
+am_librepl_la_OBJECTS = dummy.lo
librepl_la_OBJECTS = $(am_librepl_la_OBJECTS)
DEFAULT_INCLUDES = -I. -I$(srcdir) -I$(top_builddir)
depcomp = $(SHELL) $(top_srcdir)/config/depcomp
@@ -172,7 +172,7 @@ sharedstatedir = @sharedstatedir@
sysconfdir = @sysconfdir@
target_alias = @target_alias@
noinst_LTLIBRARIES = librepl.la
-librepl_la_SOURCES =
+librepl_la_SOURCES = dummy.c
librepl_la_LIBADD = @LTLIBOBJS@
all: all-am
@@ -226,6 +226,7 @@ distclean-compile:
-rm -f *.tab.c
@AMDEP_TRUE@@am__include@ @am__quote@$(DEPDIR)/realloc.Plo@am__quote@
+@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/dummy.Plo@am__quote@
.c.o:
@am__fastdepCC_TRUE@ if $(COMPILE) -MT $@ -MD -MP -MF
"$(DEPDIR)/$*.Tpo" -c -o $@ $<; \
@@ -367,7 +368,7 @@ clean-am: clean-generic clean-libtool clean-
noinstLTLIBRARIES \
mostlyclean-am
distclean: distclean-am
- -rm -rf $(DEPDIR)
+ -rm -rf $(DEPDIR) ./$(DEPDIR)
-rm -f Makefile
distclean-am: clean-am distclean-compile distclean-generic \
distclean-libtool distclean-tags
@@ -393,7 +394,7 @@ install-man:
installcheck-am:
maintainer-clean: maintainer-clean-am
- -rm -rf $(DEPDIR)
+ -rm -rf $(DEPDIR) ./$(DEPDIR)
-rm -f Makefile
maintainer-clean-am: distclean-am maintainer-clean-generic
diff --git a/repl/dummy.c b/repl/dummy.c
new file mode 100644
index 0000000..39e7442
--- /dev/null
+++ b/repl/dummy.c
@@ -0,0 +1 @@
+void dummy () { return; }
diff --git a/src/Makefile.in b/src/Makefile.in
index e9ca293..a1f5a81 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -223,6 +223,7 @@ libiml_la_CFLAGS = $(AM_CFLAGS)
libiml_la_LIBADD = $(EXTERNLIB) \
$(top_builddir)/repl/librepl.la
+libiml_la_LDFLAGS = -version-info 1:0:1
all: all-am
.SUFFIXES:
}}}
The first hunk is manually edited, as is the hunk adding the file
`repl/dummy.c`; the rest are created by running automake in the src
directory.
There are a couple of things that worry me, such as the `-version-info
1:0:1` near the end of the diff. Does that mean that autotools are
misunderstanding the version of IML as 1.0.1 instead of 1.0.3? Why does a
similar line not already exist in that file? As far as I can tell, I made
sure I was using the same versions of autotools that the authors of IML
were - autoconf 2.59, automake 1.9.6, and libtool 1.5.22.
Anyway, I'll try again with your patch instead of this dummy function and
see what's different. This time I'll also try the whole autotools suite by
running `autoreconf -i` (as recommended to me by Jeroen) - is this what
you recommend too, fbissey?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/748#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
