#11274: Cholesky matrix decomposition breaks over the rationals
----------------------------------+-----------------------------------------
       Reporter:  rbeezer         |         Owner:  jason, was     
           Type:  defect          |        Status:  positive_review
       Priority:  minor           |     Milestone:  sage-5.1       
      Component:  linear algebra  |    Resolution:                 
       Keywords:  sd40.5          |   Work issues:                 
Report Upstream:  N/A             |     Reviewers:  Dan Drake      
        Authors:  Rob Beezer      |     Merged in:                 
   Dependencies:  #12966, #13018  |      Stopgaps:                 
----------------------------------+-----------------------------------------
Changes (by ddrake):

  * status:  needs_review => positive_review
  * reviewer:  => Dan Drake


Comment:

 The exact Cholesky decomposition looks good. The only thing we might want
 is to add in the example from the description of the ticket (which now
 works) but the documentation is quite thorough, so it seems very unlikely
 that the little 2x2 case will fail with the tests we have.

 Runtime for random matrices over the rationals is fine; 100x100 matrices
 finish in about 6.2 seconds on my machine.

 Positive review to trac_11274-exact-cholesky-v1.patch.

 Apply trac_11274-cache-indefinite-factors-v1.patch and
 trac_11274-exact-cholesky-v1.patch

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11274#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to