#12612: Fix is_unit() in padics so that it is mathematically correct
----------------------------------+-----------------------------------------
Reporter: mmasdeu | Owner: roed
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-5.1
Component: padics | Resolution:
Keywords: padics is_unit | Work issues:
Report Upstream: N/A | Reviewers: David Roe, Robert Bradshaw
Authors: | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by robertwb):
* reviewer: David Roe => David Roe, Robert Bradshaw
Comment:
Wow, nice catch. I'm surprised there's not more code using this function
(though I guess a lot of the internal p-adic code is manipulating things
at a lower level).
I hope we don't break other users--I'm tempted to put in a warning, but
this should be fixed. Thoughts? Otherwise, positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12612#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
