#12553: Add interface for PALP polytope databases
--------------------------------------------+-------------------------------
       Reporter:  vbraun                    |         Owner:  was         
           Type:  enhancement               |        Status:  needs_review
       Priority:  major                     |     Milestone:  sage-5.1    
      Component:  databases                 |    Resolution:              
       Keywords:  PALP reflexive polytopes  |   Work issues:              
Report Upstream:  N/A                       |     Reviewers:              
        Authors:  Volker Braun              |     Merged in:              
   Dependencies:  #11763, #11634            |      Stopgaps:              
--------------------------------------------+-------------------------------

Comment (by Snark):

 I had a look and have some remarks to do:
 * now spkg-install checks for SAGE_DATA before using SAGE_DATA (the one in
 sage 5.0 checks SAGE_ROOT before using SAGE_DATA...), which is good!
 * the sources aren't in a directory src/ but in reflexive_polytopes/ --
 isn't it against the conventions?
 * both build.sh scripts lack a shebang ;
 * is it normal that the installation is dumping everything in
 SAGE_DATA/reflexive_polytopes/ ? Shouldn't the spkg (1) depend on palp (2)
 in the build phase, use it to create the database (3) in the install
 phase, only install the resulting database?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12553#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to