#12964: multiply matrix of matrices by a scalar: boom
-----------------------------------+----------------------------------------
Reporter: jhpalmieri | Owner: jason, was
Type: defect | Status: positive_review
Priority: major | Milestone: sage-5.1
Component: linear algebra | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Mike Hansen
Authors: Robert Bradshaw | Merged in:
Dependencies: | Stopgaps:
-----------------------------------+----------------------------------------
Changes (by {'newvalue': u'Robert Bradshaw', 'oldvalue': u'Mike Hansen'}):
* status: needs_review => positive_review
* reviewer: => Mike Hansen
* author: Mike Hansen => Robert Bradshaw
Comment:
The matrix code (changed in the first patch) assumed that you can always
call {{{_mul_}}} on the entries of the matrix in order to do
multiplication. However, this is not the case if the entries of the
matrix are in fact matrices themselves since they bypass the coercion
system, implement {{{__mul__}}} directly (which calls
{{{_matrix_times_matrix_}}}), and don't implement {{{_mul_}}}. Robert's
patch just implements {{{_mul_}}} to do "what it should" in case there are
other places that assume that you can always use {{{_mul_}}} directly.
Positive review for Robert's patch.
Apply only 12964-fix-mul.patch .
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12964#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
