#10655: Fix optional animate.py doctests
-------------------------------------------------------------+--------------
Reporter: kcrisman | Owner:
mvngu
Type: defect | Status:
needs_work
Priority: minor | Milestone:
Component: doctest | Resolution:
Keywords: convert ImageMagick animate optional sd31 | Work issues:
Report Upstream: N/A | Reviewers:
John Palmieri, Karl-Dieter Crisman
Authors: John Palmieri | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------------------------+--------------
Changes (by kcrisman):
* status: needs_review => needs_work
Comment:
Umm, the second two doctests might be optional for some reason, but they
don't require !ImageMagick. I just tested this by renaming `convert` so
that
{{{
sage -t --only-optional=ImageMagick
}}}
failed, and those tests did not shows up as ones that failed. If you look
at [http://hg.sagemath.org/sage-
main/file/9ab4ab6e12d0/sage/plot/animate.py#l291 the code], too, it
doesn't use anything except the initialization (which doesn't need
convert) and `graphics_array`, which clearly doesn't either.
I don't know what you want to do with those, but at any rate this isn't
the right solution. Maybe instead put a little note that these don't
require convert or something?
Also, please use a more descriptive commit message.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10655#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
