#12299: Advance Jmol Interactive Features in Flask Notebook
------------------------------------------------------------+---------------
Reporter: gutow | Owner:
jason, mpatel, was
Type: enhancement | Status:
needs_work
Priority: major | Milestone:
sage-5.2
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues:
very minor doc issues
Report Upstream: Workaround found; Bug reported upstream. | Reviewers:
Karl-Dieter Crisman, Steven Trogdon, Punarbasu Purkayastha
Authors: Jonathan Gutow | Merged in:
Dependencies: #11080,#11078,#11503 | Stopgaps:
------------------------------------------------------------+---------------
Changes (by kcrisman):
* status: needs_review => needs_work
* work_issues: => very minor doc issues
Comment:
> > Did you remember to to a ./sage -b to force recognition of the new
code? Only suggesting it because I keep forgetting myself...
>
> Hmm ..., well I thought I had? I even checked my history to make sure I
had. But ... after running ./sage -b "again" - I now get results exactly
as those from the !TestServer! Sorry for the noise.
Yup, this happens to everybody! Great, though - I would have been
surprised had this been different.
> Decided to keep JmolData specific error as may need it for movie
generation.
Sorry, still 'needs work'. ''Every'' method needs doctesting. In
particular, the !JmolDataError needs a docstring and test in its
{{{__init__}}} and {{{__str__}}} methods. I'm really sorry this is so
annoying. For the init, just print `self.value` or something; you can
also put {{{# indirect doctest}}} as a comment after the test (not the
result) for the ones that don't use the actual name of the method.
Also, you'll need to change things like
{{{
EXAMPLES::
Create a JmolData object
::
sage: from sage.interfaces.jmoldata import JmolData
}}}
should look like
{{{
EXAMPLES:
Create a JmolData object::
sage: from sage.interfaces.jmoldata import JmolData
}}}
Note the single colon except directly before the doctest, and the blank
line before the actual test.
Will increasing the Jmol memory cause problems? I don't have time to do
any more Jmol testing right now, how much more memory are we talking,
where does it live?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:95>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
