#13109: Rewrite deprecation to use trac ticket numbers
--------------------------------+-------------------------------------------
Reporter: vbraun | Owner: mvngu
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.1
Component: doctest | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Volker Braun | Merged in:
Dependencies: | Stopgaps:
--------------------------------+-------------------------------------------
Comment (by kcrisman):
Replying to [comment:10 vbraun]:
> I updated the patches to use the shorter url
`http://trac.sagemath.org/<number>`, no other changes.
>
> There is nothing different in doctesting deprecations from doctesting
other stuff in the Sage library, so I'm against adding an extra section on
that to the coding conventions section. Shorter is better if there is no
additional information conveyed.
Simply not true. You have
{{{
doctest:1: DeprecationWarning:
}}}
but one needs an ellipsis, and this is standard in the tests I've seen.
Probably not always necessary, but good protocol.
{{{
doctest:...: DeprecationWarning:
}}}
In fact, you even change this in several of the tests in your patch.
Also, I'm wondering why the tests pass in developer/conventions.rst when
you don't use the `doctest:` at all. Is that itself completely optional?
Now I'm confused.
In fact, even putting in a blatant error in that file doesn't cause a
problem in testing. Do these even get tested?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13109#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
