#12299: Advance Jmol Interactive Features in Flask Notebook
------------------------------------------------------------+---------------
Reporter: gutow | Owner:
jason, mpatel, was
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-5.2
Component: notebook | Resolution:
Keywords: Jmol, 3D, notebook | Work issues:
Report Upstream: Workaround found; Bug reported upstream. | Reviewers:
Karl-Dieter Crisman, Steven Trogdon, Punarbasu Purkayastha, John Palmieri
Authors: Jonathan Gutow | Merged in:
Dependencies: #11080,#11078,#11503 | Stopgaps:
------------------------------------------------------------+---------------
Comment (by kcrisman):
I like the Sage library patch. We've certainly tested all of it a fair
amount as well.
I don't have access to a computer without JVM, I guess, so maybe someone
should make sure the error message really appears in the notebook and is
friendly?
The tests now behave properly again.
Line [https://github.com/sagemath/sagenb/pull/64/files#L2R2416 2416] could
use an `os.path.join`, I guess, but that's probably not crucial.
I can't possibly review all the changes in jmol_lib.js but it certainly
mostly conforms to the changes that are advertised, and I believe strogdon
and I have tested a fair number of those capabilities. Is someone willing
to read through the changes in that file line by line to look for errors?
I honestly don't know that we're going to find a lot more without the kind
of testing one gets from active deployment. So far it seems like it's
performing admirably. Other comments?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12299#comment:118>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
