#9544: Fix flintqs on FreeBSD
----------------------------------------------------------------+-----------
Reporter: pjeremy |
Owner: pjeremy
Type: enhancement |
Status: needs_review
Priority: major |
Milestone: sage-5.2
Component: FreeBSD |
Resolution:
Keywords: | Work
issues:
Report Upstream: None of the above - read trac for reasoning. |
Reviewers: Stephen Montgomery-Smith, Jeroen Demeyer, Karl-Dieter Crisman
Authors: Peter Jeremy, Jeroen Demeyer | Merged
in:
Dependencies: #12855 |
Stopgaps:
----------------------------------------------------------------+-----------
Changes (by kcrisman):
* reviewer: Stephen Montgomery-Smith => Stephen Montgomery-Smith, Jeroen
Demeyer, Karl-Dieter Crisman
Comment:
> > Jeroen, did you try this out on some of the buildbots?
> No, but I don't expect problems. What harm could an additional header
file do?
I don't know, that's why I asked! Extra imports in Python sometimes cause
all kinds of circularity issues or slowdowns, and I don't know enough
about C to say either way.
But since you just repackaged this, I think it's appropriate for you to be
a reviewer as well. And I checked that the package is well-formed and
installs on OS X.
I also notice that you included stdint after stdlib, while Stephen does
the opposite in his patch
[http://www.freebsd.org/cgi/cvsweb.cgi/ports/math/sage/files/spkg-patch-
flintqs-20070817.p6_-_patches_TonelliShanks.h.patch?rev=1.1;content-
type=text%2Fplain here]. I assume this also doesn't matter? Sorry for
the very stupid questions.
----
See also #11792?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9544#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
