#11851: make pybtex an optional spkg
------------------------------------------------+---------------------------
       Reporter:  ranosch                       |         Owner:  tbd          
           Type:  task                          |        Status:  needs_review 
       Priority:  major                         |     Milestone:  sage-5.1     
      Component:  optional packages             |    Resolution:               
       Keywords:  BibTeX citations              |   Work issues:               
Report Upstream:  N/A                           |     Reviewers:  John Palmieri
        Authors:  Niels Ranosch, Burcin Erocal  |     Merged in:               
   Dependencies:                                |      Stopgaps:               
------------------------------------------------+---------------------------
Changes (by jhpalmieri):

  * reviewer:  => John Palmieri


Comment:

 Yes, that looks good now. Regarding spkg-install, you don't really need to
 create and delete the directory `tmp`: I think you can just unzip and
 build !PyYAML-3.10.zip in place:
 {{{
 #!diff
 diff --git a/spkg-install b/spkg-install
 --- a/spkg-install
 +++ b/spkg-install
 @@ -6,19 +6,19 @@ if [ "x$SAGE_LOCAL" = x ]; then
     exit 1
  fi

 +CUR=`pwd`
 +
  # need to suppress confusing error messages and don't depend on system
  # libraries, so easy_install is not available
 -mkdir tmp &&
 -    unzip -o PyYAML-3.10.zip -d tmp &&
 -    cd tmp/PyYAML-3.10 &&
 +unzip -o PyYAML-3.10.zip &&
 +    cd PyYAML-3.10 &&
      python setup.py --without-libyaml install --prefix="$SAGE_LOCAL"
  if [ $? -ne 0 ]; then
     echo "Error installing PyYAML."
     exit 1
  fi

 -cd ../..
 -rm -rf tmp
 +cd "$CUR"

  easy_install pyparsing-1.5.6.zip
  if [ $? -ne 0 ]; then
 }}}
 But this is not very important; it works either way.

 So if you upgrade the spkg to use your new version of SPKG.txt, you can
 switch this to "positive review".

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11851#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to