#12798: list_plot3d plots extraneous points at z=0 and doesn't take color or
rgbcolor as keywords
--------------------------------------------------------------+-------------
Reporter: ppurka | Owner:
jason, was
Type: defect | Status:
new
Priority: major | Milestone:
sage-5.2
Component: graphics | Resolution:
Keywords: list_plot3d, sd40.5 | Work issues:
Report Upstream: N/A | Reviewers:
Karl-Dieter Crisman, Punarbasu Purkayastha
Authors: Punarbasu Purkayastha, Karl-Dieter Crisman | Merged in:
Dependencies: | Stopgaps:
--------------------------------------------------------------+-------------
Comment (by ppurka):
This is befuddling. The main time consuming doctest that is added is the
`num_points=400` one. And here are the doctest times. The starting point
is sage-5.2.alpha0 with these patches added, on an `Intel(R) Core(TM)2 CPU
6400 @ 2.13GHz` ubuntu 12.04.
1. First, with `f.default_value = 0.0` missing from the file (this is the
change introduced by the patches in this ticket).
{{{
...age-5.2.alpha0/devel/sage» ../../sage -b >& /dev/null
...age-5.2.alpha0/devel/sage» ../../sage -t -long
sage/plot/plot3d/list_plot3d.py
sage -t -long "devel/sage-main/sage/plot/plot3d/list_plot3d.py"
[13.5 s]
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 13.5 seconds
}}}
2. Second test with `f.default_value = 0.0`. Note that at this point, the
extra examples introduced by the patches in this ticket are still there in
the file.
{{{
...age-5.2.alpha0/devel/sage» ../../sage -b >& /dev/null
...age-5.2.alpha0/devel/sage» ../../sage -t -long
sage/plot/plot3d/list_plot3d.py
sage -t -long "devel/sage-main/sage/plot/plot3d/list_plot3d.py"
[16.3 s]
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 16.3 seconds
}}}
3. Third, with `f.default_value = float('inf')`, and otherwise the patches
in this ticket are still applied, i.e., the extra examples are still
present.
{{{
...age-5.2.alpha0/devel/sage» ../../sage -b >& /dev/null
...age-5.2.alpha0/devel/sage» ../../sage -t -long
sage/plot/plot3d/list_plot3d.py
sage -t -long "devel/sage-main/sage/plot/plot3d/list_plot3d.py"
[12.8 s]
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 12.8 seconds
}}}
4. Finally, with all the patches unapplied. This is vanilla
sage-5.2.alpha0 and hence the examples introduced by the patches in this
ticket are not present.
{{{
...age-5.2.alpha0/devel/sage» hg qpop -a
popping trac_12798-more-doc.2.patch
popping trac_12798-fix_extraneous_points_and_kwds_in_list_plot3d.patch
popping trac_9774-doctests.patch
popping trac_9774-mathjax-try5.patch
patch queue now empty
...age-5.2.alpha0/devel/sage» ../../sage -b >& /dev/null
...age-5.2.alpha0/devel/sage» ../../sage -t -long
sage/plot/plot3d/list_plot3d.py
sage -t -long "devel/sage-main/sage/plot/plot3d/list_plot3d.py"
[6.3 s]
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 6.3 seconds
}}}
Note that correct plots are generated only by 1. and 3. At least on this
machine, both 1. and 3. are faster than the code already present in
vanilla sage-5.2.alpha0. It is only the example with `num_points=400` that
introduces the slowdown.
So, I am attaching an updated patch which reduces the `num_points`. Here
is the time taken for this new one. Notice that the time taken is
''lower'' than the vanilla sage-5.2.alpha0, even though the number of
examples doctested has increased.
{{{
...age-5.2.alpha0/devel/sage» hg qpush trac_12798-more-doc.2.patch
applying trac_9774-mathjax-try5.patch
applying trac_9774-doctests.patch
applying trac_12798-fix_extraneous_points_and_kwds_in_list_plot3d.patch
applying trac_12798-more-doc.2.patch
now at: trac_12798-more-doc.2.patch
...age-5.2.alpha0/devel/sage» hg qref
...age-5.2.alpha0/devel/sage» ../../sage -b >& /dev/null
...age-5.2.alpha0/devel/sage» ../../sage -t -long
sage/plot/plot3d/list_plot3d.py
sage -t -long "devel/sage-main/sage/plot/plot3d/list_plot3d.py"
[4.4 s]
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 4.4 seconds
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12798#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
