#13073: recognition of weakly chordal graphs
--------------------------------------------------+-------------------------
Reporter: eisermbi | Owner: jason,
ncohen, rlm
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-5.1
Component: graph theory | Resolution:
Keywords: weakly chordal, hole, antihole | Work issues:
Report Upstream: N/A | Reviewers: Nathann
Cohen,Birk Eisermann
Authors: Birk Eisermann | Merged in:
Dependencies: | Stopgaps:
--------------------------------------------------+-------------------------
Changes (by ncohen):
* reviewer: Nathann Cohen => Nathann Cohen,Birk Eisermann
Comment:
Helloooooo Birk !!
Well, the code looks nice to me, it is tested, documented, sligthly
optimized... I would say that we are done with it !
I just built the doc again and saw that there remained a conflict with the
references... Of course : the paper is cited in one of the module's
functions, and this function is also loaded inside of Graph, so it appears
twice in Sphinx's view of the code.. I add a small patch that moves it
inside of the module's doc, and the warning disappears as a result.
I also uploaded a patch that contains all the other ones, to make it
easier for Jeroen.
As I agree with all your code and changes, you can set this ticket to
"positive_review" if you also agree with my part `:-)`
Thaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaanksss !!
Nathann
The following patch:
* [attachment:trac_13073-all.patch]
Contains all of the following :
* [attachment:trac_13073_weaklychordal-module.patch]
* [attachment:trac_13073_weaklychordal-review.patch]
* [attachment:trac_13073-optim.patch]
* [attachment:trac_13073-optim-review.2.patch]
* [attachment:trac_13073-sphinx-warning.patch]
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13073#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
