#13196: GL(n, GF(q)).random_element() is way too slow for what it does
--------------------------------------------------------------+-------------
       Reporter:  Bouillaguet                                 |         Owner:  
joyner         
           Type:  enhancement                                 |        Status:  
positive_review
       Priority:  trivial                                     |     Milestone:  
sage-5.2       
      Component:  group theory                                |    Resolution:  
               
       Keywords:  matrix group, finite field, random element  |   Work issues:  
               
Report Upstream:  N/A                                         |     Reviewers:  
               
        Authors:  Charles Bouillaguet                         |     Merged in:  
               
   Dependencies:                                              |      Stopgaps:  
               
--------------------------------------------------------------+-------------

Comment (by jlopez):

 I know this is positively reviewed already, but may I suggest a small
 improvement? The `MatrixSpace.random_element()` method creates a zero
 matrix and then randomizes every entry by calling the `M.randomize()`
 method. We can avoid recreating the zero matrix in every iteration by
 calling directly the `randomize()` method. For large matrices this gives
 me a 5-10% speed improvement over your current patch.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13196#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to