#13217: Expand the Dedekind eta function more efficiently
---------------------------------+------------------------------------------
       Reporter:  arminstraub    |         Owner:  craigcitro
           Type:  enhancement    |        Status:  needs_work
       Priority:  minor          |     Milestone:  sage-5.2  
      Component:  modular forms  |    Resolution:            
       Keywords:                 |   Work issues:            
Report Upstream:  N/A            |     Reviewers:            
        Authors:  Armin Straub   |     Merged in:            
   Dependencies:                 |      Stopgaps:            
---------------------------------+------------------------------------------
Changes (by chapoton):

  * status:  needs_review => needs_work


Comment:

 * Maybe you could use

 assert prec>0, "prec must be a positive integer"

 instead of the ValueError that you have written

 * You have to change the "n" into "prec" also in the OUTPUT block

 * Maybe you could remove the comment "we pass this as an argument as .."
 in the INPUT block, which does not seem to be very useful.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13217#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to