#5489: Add an interface for 4ti2 to Sage
-------------------------------+--------------------------------------------
Reporter: mhansen | Owner: was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.3
Component: interfaces | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: | Merged in:
Dependencies: | Stopgaps:
-------------------------------+--------------------------------------------
Comment (by chapoton):
The code looks good, the doc coverage is 100% and the tests pass. I am
almost ready to give a positive review.
I have only some basic comments:
* there is a typo here in "does" (in the method directory)
{{{
# method since apparently importing sage.misc.misc oes not
}}}
* Why not gather these import statements at the beginning ?
{{{
from sage.matrix.constructor import matrix
from sage.matrix.matrix import is_Matrix
from sage.rings.integer_ring import ZZ
import subprocess
}}}
If there is no technical difficulty (as for sage.misc.misc), it seems
better to import them once and for all. At least those about matrices and
integers ?
* There seem to be some 'trailing whitespaces' that could be removed. All
the lines just after an EXAMPLES:: should rather be empty.
* The minimize method is NotImplemented. This can of course wait for
another ticket.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5489#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
