#13290: Upgrade MPC to version 1.0
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: tbd
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-5.3
Component: packages | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by leif):
`s/Gnu Mpc/GNU MPC/` in `SPKG.txt` ;-) (The original has small caps.)
For consistency, I wouldn't remove the error check and message in `spkg-
check`.
I also wouldn't comment out the patch loop; in case there are no patches,
simply no patch should get applied, without raising an error message
(either because `patches/` doesn't exist, or because there's no patch in
`patches/` such that `../patches/*.patch` "expands" to itself). Otherwise
we uselessly keep creating and deleting directories, and commenting code
out or reversing that each time patches again appear or all previous
patches vanish. Prepending
{{{
#!sh
ls ../patches/*.patch &>/dev/null &&
}}}
to the `for` loop should be sufficient.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13290#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
