#13130: Ring support for projective space points and morphisms
-----------------------------------------+----------------------------------
Reporter: bhutz | Owner: bhutz
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-5.3
Component: algebraic geometry | Resolution:
Keywords: projective space ring | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Ben Hutz | Merged in:
Dependencies: | Stopgaps:
-----------------------------------------+----------------------------------
Comment (by novoselt):
For the original patch:
* `NOTES::` should be formatted as `.. note::`
* Names of methods, types, etc. should be at the very least double quoted
like {{{``__eq__``}}} or better yet referred to like
{{{:class:`ValueError`}}}
* Why `_element_constructor_` was removed? It is part of the coercion
framework and it is likely that it has to be present.
* It looks to me like the code of `class
SchemeMorphism_polynomial_projective_space` was moved inside the same
file. Why? Was it changed?
* Input/output is not documented everywhere and formatting is not always
correct. See http://www.sagemath.org/doc/developer/conventions.html
#documentation-strings
* `dimension` method is defined to just return `relative_dimension`
Why??? `dimension` does work already and works differently:
{{{
sage: ProjectiveSpace(3,QQ["y"],'x').dimension_relative()
3
sage: ProjectiveSpace(3,QQ["y"],'x').dimension()
4
}}}
The patch breaks backward compatibility and makes dimension inconsistent
between different spaces.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13130#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
