#12181: random_DAG does not terminate on it's default inputs
------------------------------------------+---------------------------------
Reporter: mderickx | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.3
Component: graph theory | Resolution:
Keywords: random digraph | Work issues:
Report Upstream: N/A | Reviewers: David Coudert
Authors: dsm, Frédéric Chapoton | Merged in:
Dependencies: | Stopgaps:
------------------------------------------+---------------------------------
Comment (by dcoudert):
That's right, you should change the test to
{{{
assert 0 < p and p <= 1, "The parameter p must satisfy 0 < p <= 1."
}}}
You don't have the change the rest of the code since the {{{random()}}}
function returns a value strictly less than 1.
Concerning the documentation. For (almost?) all modules, you can find the
functions in the reference manual of sage
(http://www.sagemath.org/doc/reference/). Then, when testing a patch, we
use the command
{{{sage -docbuild reference html}}}
to build the reference manual including patch's changes. Same for
{{{thematic_tutorials}}} if any.
However, the sandpile model is not included in the reference manual.
I have open a new ticket to address this issue (#13342).
So, you have to:
- change the test on p
- change the commit message of this patch. It is currently
{{{
#12181 bug in random digraphs with probability zero
}}}
It should be something like
{{{
trac #12181 -- Fix bugs with the input parameters of the random_DAG
function
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12181#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
