#13345: Test if the assumptions made by quotient rings are fulfilled
----------------------------------+-----------------------------------------
Reporter: tfeulner | Owner: AlexGhitza
Type: defect | Status: new
Priority: major | Milestone: sage-5.3
Component: algebra | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Thomas Feulner | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by mstreng):
Judging just from reading the patch, I think you make the assumption very
clear :)
I don't have any experience with deprecation, but what you're doing to
sage/rings/ideal.py looks fine to me.
About the {{{DeprecationWarning}}} you are adding to
sage/rings/quotient_ring.py:
1) Any existing Sage doctest where your patch gives this warning is very
likely a Sage bug. Thanks for finding them, you can list them in a
separate ticket.
2) For your final patch, please remove this test and this warning. There
is not much added benefit of this warning (you get an indirect warning
from reduce when you use the quotient ring anyway), and it tests something
different from what it claims to check (reduce being implemented is not
equivalent to the assumption being satisfied, so lots of potential false
positives and false negatives), while it also forces people to do extra
work later (when the deprecated function "reduce" is changed to
{{{NotImplementedError}}}). Also, you are not deprecating any
functionality at this location in the source code.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13345#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
