#11641: Implementation of decorator for combinatorial statistics and maps
-------------------------------------------+--------------------------------
Reporter: stumpc5 | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-pending
Component: combinatorics | Resolution:
Keywords: combinatorial statistic | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Christian Stump | Merged in:
Dependencies: | Stopgaps:
-------------------------------------------+--------------------------------
Comment (by sluther):
1) Please don't use assert, raise ValueError instead. \\
2) When returning self._black_list in black_list(), make a copy. i.e.
return self._back_list[:]. Otherwise modifications to the returned list
will also modify self._black_list. \\
3) {{{return self._f(self._inst,*args,**kwds)}}} has missing white space
between the arguments\\
4) In combinatorial_maps_in_class(), you search a unsorted list on every
iteration. Either make 'result' a set and possibly convert it into a list
on return
or if the order matters, use a set next to the list.
5) In the first doc string "defined a map between two combinatorial
objects." defined should be defines.
These two classes share a lot of code. Have you though about a way to
avoid this duplication?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11641#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
