#715: Parents probably not reclaimed due to too much caching
-------------------------------------------------------------------+--------
Reporter: robertwb |
Owner: somebody
Type: defect |
Status: needs_work
Priority: major |
Milestone: sage-pending
Component: coercion |
Resolution:
Keywords: weak cache coercion Cernay2012 | Work
issues:
Report Upstream: N/A |
Reviewers: Jean-Pierre Flori, Simon King
Authors: Simon King, Jean-Pierre Flori | Merged
in:
Dependencies: #9138, #11900, #11599, to be merged with #11521 |
Stopgaps:
-------------------------------------------------------------------+--------
Changes (by nbruin):
* status: positive_review => needs_work
Comment:
When reviewing #12313 I observed a possible problem for slight leaking
(see [http://trac.sagemath.org/sage_trac/ticket/12313#comment:125 comment
125]):
When all `KeyRef` objects under a certain key in `_refcache` get deleted,
I think you're left with a `{<key> : []}` entry in `_refcache`. So I think
in `TripleDictEraser.__call__` you need an extra line:
{{{
cdef list L = _refcache[k1,k2,k3]
del L[L.index(r)]
if len(L)==0:
del _refcache[k1,k2,k3]
}}}
or whatever is the best way to remove such things.
Similar on #12313 in `MonoDictEraser.__call__` of course.
By all means, if you have a good argument why this is not necessary,
revert to Positive Review (and I'd be interested in seeing the argument).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/715#comment:198>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
