#13251: Add General Dihedral Groups as Permutation Groups
--------------------------------+-------------------------------------------
       Reporter:  khalasz       |         Owner:  joyner         
           Type:  enhancement   |        Status:  positive_review
       Priority:  minor         |     Milestone:  sage-5.3       
      Component:  group theory  |    Resolution:                 
       Keywords:                |   Work issues:                 
Report Upstream:  N/A           |     Reviewers:  Benjamin Jones 
        Authors:  Kevin Halasz  |     Merged in:                 
   Dependencies:                |      Stopgaps:                 
--------------------------------+-------------------------------------------
Changes (by benjaminfjones):

  * status:  needs_review => positive_review


Old description:

> Implements the finite Generalized dihedral groups.
> A Generalized dihedral group is the semi-direct product of an abelian
> group with C2, where C2 acts on the abelian group by sending elements to
> their inverse.
> This adds a group of order 18 that is not part of any other family
> currently implemented in sage, as well as others of not so small order.
>
> '''Apply'''
>   1. [attachment: 13251_generaldihedralgroups-v2.patch]

New description:

 Implements the finite Generalized dihedral groups.
 A Generalized dihedral group is the semi-direct product of an abelian
 group with C2, where C2 acts on the abelian group by sending elements to
 their inverse.
 This adds a group of order 18 that is not part of any other family
 currently implemented in sage, as well as others of not so small order.

 '''Apply'''
   1. [attachment:13251_generaldihedralgroups-v2.2.patch]

--

Comment:

 Everything came back good. I attached a reviewer patch to clean up some
 trailing whitespace from your most recent patch. This isn't a bug deal,
 just a cosmetic thing (and not everyone agrees on what should be done
 about it).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13251#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to