#13391: WeylCharacterRing improvement
------------------------------------------+---------------------------------
Reporter: bump | Owner: bump
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.4
Component: combinatorics | Resolution:
Keywords: WeylCharacterRing, Lie | Work issues:
Report Upstream: N/A | Reviewers: Anne Schilling
Authors: Daniel Bump | Merged in:
Dependencies: | Stopgaps:
------------------------------------------+---------------------------------
Comment (by aschilling):
Hi Dan,
I think in your commit message, you can delete the two lines
{{{
imported patch weyl_characters.patch
* * *
}}}
I ran
{{{
sage -coverage weyl_characters.py
----------------------------------------------------------------------
weyl_characters.py
SCORE weyl_characters.py: 94% (63 of 67)
Missing doctests:
* __pow__(self, n):
* irreducible_character_freudenthal(hwv, L, debug=False):
* get_branching_rule(Rtype, Stype, rule):
* __classcall__(cls, parent, prefix=None):
Possibly wrong (function name doesn't occur in doctests):
* _repr_(self):
* product_on_basis(self, a, b):
* simple_coroots(self):
* _repr_(self):
* product_on_basis(self, a, b):
* _repr_term(self, t):
}}}
Since the method {{{__pow__(self, n)}}} is new, I suppose at least this
method should have a doctest. You can add #indirect doctest behind tests
that indirectly test the function. Then sage -coverage probably won't
complain about the possibly wrong functions any longer.
In the docstring for the method dot_reduce, I think you want the line
"Auxiliary function for product_on_basis."
as the first line. Then INPUT: and the - ``a`` ... with the same indent at
INPUT.
Anne
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13391#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
