#12876: Fix element and parent classes of Hom categories to be abstract, and
simplify the Hom logic.
------------------------------------------+---------------------------------
Reporter: nthiery | Owner: nthiery
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.4
Component: categories | Resolution:
Keywords: categories, Hom | Work issues: add commit message
to one patch
Report Upstream: N/A | Reviewers: Simon King
Authors: Nicolas M. Thiéry | Merged in:
Dependencies: #11521, #12215, #12313 | Stopgaps:
------------------------------------------+---------------------------------
Comment (by nthiery):
Replying to [comment:71 SimonKing]:
> I give it a positive review, modulo commit message of
> [attachment:trac_12876_category-fix_abstract_class-nt-rel11521-review-
nt.patch]
> and modulo the small reviewer patch that I have attached. I think it
> should be `.. todo::` and not `..TODO::` (note the blank space).
Thanks for fixing the space. Apparently, there is some sort of
consensus for using .. TODO:: rather than .. todo:: (same thing
for seealso, ...).
I have checked the change on infinite polynomial rings, and am ok with
it.
Do you mind folding all patches together? Now that we have checked the
little steps, that will leave a better overview for the future. And
that will take care of the commit messages :-)
(or I can do it, but I need to get the latest beta version first).
And then, it's ready for positive review! Yippee!
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12876#comment:76>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
