#13404: Improved printing for symmetric function bases and misc refactoring
---------------------------------------+------------------------------------
Reporter: nthiery | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.4
Component: combinatorics | Resolution:
Keywords: symmetric functions | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nicolas M. Thiéry | Merged in:
Dependencies: #13399 | Stopgaps:
---------------------------------------+------------------------------------
Comment (by nthiery):
Hi Anne,
Replying to [comment:12 aschilling]:
> I looked over the patch and overall it looks very good to me. Thanks,
Nicolas, for making these changes!
You are welcome!
> Just a quick questions: so this is now consistent with NSym and QSym,
right?
Yes! Well, almost: there remains the on->in change for NSym and Qsym
(and in general "with realizations"), but that's for another patch.
> Don't you want to keep some tests when q is set to a value or both
parameters are set to a value?
That would have been better indeed. That being said, the doctests of
SymmetricFunctionsBases.ParentMethods._repr_ includes an example with
two parameters, and the failure when q is wrong is tested in
Macdonald.__init__; so if you don't mind I'll be lazy and leave things
as is.
> Also, where is zee specified in this code?
{{{
1519 def _dual_basis_default(self):
1520 ...
1548 return self.dual_basis(scalar=zee, scalar_name =
"Hall scalar product")
^^^ Here ?
}}}
> Other than these questions I am happy to set a positive review!
Thanks!
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13404#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
