#9906: Move the RPy package outside of the R package
--------------------------------------------------+-------------------------
       Reporter:  mpatel                          |         Owner:  leif        
       
           Type:  defect                          |        Status:  
needs_review       
       Priority:  major                           |     Milestone:  sage-5.4    
       
      Component:  packages                        |    Resolution:              
       
       Keywords:  r-project spkg                  |   Work issues:              
       
Report Upstream:  N/A                             |     Reviewers:  Karl-Dieter 
Crisman
        Authors:  Leif Leonhardy, Jeroen Demeyer  |     Merged in:              
       
   Dependencies:  #13428, #13395                  |      Stopgaps:              
       
--------------------------------------------------+-------------------------

Comment (by jhpalmieri):

 There is also some general cleanup that could happen; for example:
 {{{
 #!diff
 diff --git a/spkg-install b/spkg-install
 --- a/spkg-install
 +++ b/spkg-install
 @@ -67,15 +67,6 @@ if [ "$UNAME" = "SunOS" ]; then
      SUN_FLAGS="--without-ICU"; export SUN_FLAGS
  fi

 -# let's remove old install, even the wrongly installed ones
 -rm -rf "$SAGE_LOCAL"/lib/r
 -rm -rf "$SAGE_LOCAL"/lib/R
 -rm -rf "$SAGE_LOCAL"/lib64/R
 -rm -rf "$SAGE_LOCAL"/lib64/r
 -# and let's also nuke some leftovers on SAGE_LOCAL/lib
 -rm -rf "$SAGE_LOCAL"/lib/libRblas.so "$SAGE_LOCAL"/lib/libRlapack.so
 "$SAGE_LOCAL"/lib/libR.so
 -rm -rf "$SAGE_LOCAL"/lib/libRblas.dylib
 "$SAGE_LOCAL"/lib/libRlapack.dylib "$SAGE_LOCAL"/lib/libR.dylib
 -
  cd src

  # Apply patches.  See SPKG.txt for information about what each patch
 @@ -131,6 +122,15 @@ if [ $? -ne 0 ]; then
      exit 1
  fi

 +# Before installing, remove old install, even the wrongly installed ones.
 +rm -rf "$SAGE_LOCAL"/lib/r
 +rm -rf "$SAGE_LOCAL"/lib/R
 +rm -rf "$SAGE_LOCAL"/lib64/R
 +rm -rf "$SAGE_LOCAL"/lib64/r
 +# and let's also nuke some leftovers on SAGE_LOCAL/lib
 +rm -rf "$SAGE_LOCAL"/lib/libRblas.so "$SAGE_LOCAL"/lib/libRlapack.so
 "$SAGE_LOCAL"/lib/libR.so
 +rm -rf "$SAGE_LOCAL"/lib/libRblas.dylib
 "$SAGE_LOCAL"/lib/libRlapack.dylib "$SAGE_LOCAL"/lib/libR.dylib
 +
  # Disable parallel make install, which is supposedly broken
  $MAKE -j1 vignettes  # Needed for help system
  $MAKE -j1 install
 @@ -168,7 +168,7 @@ if [ $? -ne 0 ] || [ ! -f "$SAGE_ROOT"/s
  fi

  if [ "$UNAME" = "Darwin" ]; then
 -    echo "Copying fake java and javac compiler on OSX"
 +    echo "Removing fake java and javac compiler on OSX."
      rm -f "$SAGE_LOCAL"/bin/java
      rm -f "$SAGE_LOCAL"/bin/javac
  fi
 }}}
 Should this happen on another ticket?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9906#comment:44>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to