#10527: Implementation of quiver mutation type
-----------------------------------------------+----------------------------
Reporter: stumpc5 | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.3
Component: combinatorics | Resolution:
Keywords: quiver mutation type days38 | Work issues:
Report Upstream: N/A | Reviewers: Hugh Thomas
Authors: Christian Stump | Merged in:
Dependencies: | Stopgaps:
-----------------------------------------------+----------------------------
Comment (by nthiery):
Replying to [comment:96 hthomas]:
> I posted a thread on sage-devel about the sagepad.org patchbot -- it
seems to be having a problem, as it is failing every patch.
>
> Volker's patchbot, though, Fedora/17/x86_64/3.5.2-3.fc17.x86_64/volker-
desktop.stp.dias.ie, seems to be being confused by the lazy import.
(Search for "lazy_import" in the patchbot log file.)
>
> I don't know what the right thing to do about that is. The easy option
would be to change the import back to normal, and leave it to someone else
who knows lazy imports (and maybe also the patchbot) better, to fix it.
Since there is no special reason that the cluster stuff has to be lazily
imported, this seems pretty reasonable to me.
I looked a bit, and the place it is failing at is when trying to
figure out which names would be imported by the "*"
(sage.misc.lazy_import.get_star_imports). And indeed this piece is a
bit tricky and therefore likely to be brittle.
I would suggest to avoid using the "*" feature of lazy_import by either:
(1) Puting explicitely in combinat.all the list of things to be lazily
imported:
lazy_import("sage.combinat.cluster_algebra_quiver.all",
"QuiverMutationType,...", overwrite=False)
(2) Replace the "lazy import *" in combinat.all by a usual import *,
and use instead lazy imports on each piece in
sage.combinat.cluster_algebra_quiver.all
Solution 2 has the advantage of not having to touch again combinat.all
in later patches, knowing that this file is very often changed and
therefore a source of potential conflicts.
By the way: unless there is a strong reason not to, I would not leave
"overwrite" to its default value.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10527#comment:97>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
