#13431: Add sign as an alias for signature for permutations
---------------------------------+------------------------------------------
       Reporter:  cremona        |         Owner:  tbd         
           Type:  enhancement    |        Status:  needs_review
       Priority:  minor          |     Milestone:  sage-5.4    
      Component:  combinatorics  |    Resolution:              
       Keywords:  permutation    |   Work issues:              
Report Upstream:  N/A            |     Reviewers:              
        Authors:                 |     Merged in:              
   Dependencies:                 |      Stopgaps:              
---------------------------------+------------------------------------------
Changes (by rbeezer):

  * status:  new => needs_review
  * component:  PLEASE CHANGE => combinatorics


Comment:

 Dear Kevin,

 That should work.

 A simpler option is to just add the line

 {{{
 sign = signature
 }}}

 immediately below the `signature` method (with a blank line and maybe a
 comment about the line being an alias), indented at the same level as the
 `def` of the method.  (Then you have two names for the same function,
 hence an alias.)

 But then you should make it clear in the docstring for the `signature()`
 method that `sign()` is indeed an alias.  This can be done nicely with a
 {{{..note}}} block, and an example or two.

 In current patch, `p` should ideally be `self` and you have `EXAMPLES::`
 twice.

 I think doing the one new line of code would be preferable to a whole new
 method.

 Rob

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13431#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to