Turadg said:
I've added this unit test, PasCurnitCompatibility, as I described in my
previous e-mail and in PAS-361.

I chose BuildPas0001 as the curnit to test against since it has the
most stuff in it.  So I ran that and put the resulting curnit archive
in src/test/resources in org.telscenter.pas.curnits package.  The
PasCurnitCompatibility test loads that up, unmarshalls it and assembles
it.  If any of that doesn't does succeed (e.g. due to
non-backwards-compatible changes in the codebase) an exception will be
thrown and the test will fail.

As Cynick has suggested, it would be a good practice to run tests
within Eclipse before submitting.  But since we do have a continuous
integration server (Continuum), I propose we see how well it works at
finding problems once there are good tests available for it to run.
Maybe we should hook up the Jabber notification transport so developers
are notified immediately if something they checked in has caused a
problem.


Laurel said:
Playing devil's advocate here...seems to me like no one pays much
attention to build failures once code is committed. I get 10's of code
build failures every day and they continue to come. Wouldn't it make
sense to run tests in advance so that a build failure was a rare thing
rather than a daily occurence? That way people might pay a little more
attention and actually fix errors rather than letting them continue for
days on end.





Turadg said:That's a good point, Laurel.

There are build bugs that are local within a project and there are
build bugs that arise from incompatible changes to dependencies.
Running the unit tests within a project will catch the local bugs
before committing.  That should be done and the code shouldn't be
committed until it's passing all the tests.  Some bugs (that cross
dependencies) can only be caught by the CI server, but I agree that the
ones that can be caught before commit should be caught and fixed before
committing.

-Turadg


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"SAIL-Dev" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/SAIL-Dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to