On Sun, 2002-12-01 at 14:58, [EMAIL PROTECTED] wrote: > On Sun, Dec 01, 2002 at 03:16:59AM +0000, [EMAIL PROTECTED] wrote: > > > > Date: Sun Dec 1 03:16:59 2002 > > Author: abartlet > > > > Update of /data/cvs/samba/source/smbd > > In directory dp.samba.org:/tmp/cvs-serv29592/smbd > > > > Modified Files: > > reply.c > > Log Message: > > No need for fstring manipulation here (Tcon&X), just use string pointers. > > Just a hint on quick review of the patch. > Be careful of using data direct from the client here.....
I just double-checked it, and as long as that STR_TERMINATE does it's job, the most we will encounter is a strequal() or a Get_Pwnam(). (for homes magic). However it might be a good idea to put a limit on the string size in make_connection() due to the complexity of our 'magic services'... > If you think it's good, please merge all these to 3.0. Yep, just looking at all the other things I need to merge as well. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
signature.asc
Description: This is a digitally signed message part
