On Fri, 2003-06-06 at 17:56, [EMAIL PROTECTED] wrote: > > Date: Fri Jun 6 07:56:23 2003 > Author: jra > > Update of /data/cvs/samba/source/lib > In directory dp.samba.org:/tmp/cvs-serv21046/lib > > Modified Files: > Tag: SAMBA_3_0 > charcnv.c > Log Message: > Fix for valgrind - when doing a srvstr_push we must zero fill > any extra bytes, not clobber region them - otherwise valgrind > thinks they are invalid on send() or write(). > Jeremy.
I think we can be more specific here - why not just do it for srvstr_push()/clistr_push()? We could do that with a small patch to add in an extra flag for 'zero out' instead of 'clobber'. Or we could do even a bit more, and add a flag to srvstr_push()/clistr_push() for this specifically - this would mean that we could still clobber for 'p += srvstrpush()' invocations, but not for 'fill this buffer'. Indeed, when we are trying to fill out a buffer, we probably want to do that always, not just for -DDEVELOPER. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
signature.asc
Description: This is a digitally signed message part
