On Sat, 2003-05-31 at 11:48, [EMAIL PROTECTED] wrote: > > Date: Sat May 31 01:48:59 2003 > Author: jra > > Update of /data/cvs/samba/source/smbd > In directory dp.samba.org:/tmp/cvs-serv26772/smbd > > Modified Files: > Tag: SAMBA_3_0 > connection.c negprot.c > Log Message: > Fixes to stop valgrind complaining about uninitialised memory when it's > copying clobbered buffer areas and doing hashes on them and sending > them onto the wire. > Jeremy. > > > Revisions: > connection.c 1.46.2.5 => 1.46.2.6 > > http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/connection.c?r1=1.46.2.5&r2=1.46.2.6 > negprot.c 1.62.2.8 => 1.62.2.9 > > http://www.samba.org/cgi-bin/cvsweb/samba/source/smbd/negprot.c?r1=1.62.2.8&r2=1.62.2.9
I think this is the wrong fix - for the connection.c stuff (which we don't send to the wire) we should tdb_pack() the key, not use a C struct. For the negprot case we should return our GUID, not the netbios name. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
signature.asc
Description: This is a digitally signed message part
