On Sun, 2003-06-22 at 15:12, Richard Sharpe wrote: > On Sun, 22 Jun 2003, Andrew Bartlett wrote: > > > On Sat, 2003-06-21 at 09:57, Richard Sharpe wrote: > > > On Thu, 19 Jun 2003, Tim Potter wrote: > > > > > > > On Wed, Jun 18, 2003 at 02:20:23PM +0000, [EMAIL PROTECTED] wrote: > > > > > > > > > Modified Files: > > > > > Tag: SAMBA_3_0 > > > > > wbinfo.c > > > > > Log Message: > > > > > Remove the -A option of wbinfo, leaving only the long version, > > > > > --set-auth-user. There was enough confusion, as in bug #158, > > > > > when a user accidentally typed -A instead of -a, and would get themselves > > > > > stuck with a non-working winbind. > > > > > > > > Nice one. I've done this myself a couple of times. That should have > > > > been a hint. (-: > > > > > > Hmmm, but do we really want to do that? I like having short forms like > > > that, and surely we could test that information presented works before > > > writing it to the secrets file? > > > > Short-forms of things are good, when you do something often - but this > > is a once-off command. Anyway, the information probably would work, so > > that test isn't that useful... > > I am sorry, that is just not true. What about the case where the admin > gets the authentication information incorrect? We should be checking the > info they provide to prevent the admin from having to hunt around for the > reason for subsequent failure.
Sorry, I wasn't clear - yes, we should test the info before we start it. Be warned that it's not quite as trivial as it should be (unless you want to turn wbinfo into something the size of 'net' just to do it). What I meant was that we can't just keep -A and -a on the basis that we we can tell if the user stuffed up - given that they both take the same input parameter format. Andrew Bartlett -- Andrew Bartlett [EMAIL PROTECTED] Manager, Authentication Subsystems, Samba Team [EMAIL PROTECTED] Student Network Administrator, Hawker College [EMAIL PROTECTED] http://samba.org http://build.samba.org http://hawkerc.net
signature.asc
Description: This is a digitally signed message part
