Author: metze
Date: 2004-08-20 13:24:28 +0000 (Fri, 20 Aug 2004)
New Revision: 1957

WebSVN: 
http://websvn.samba.org/websvn/changeset.php?rep=samba&path=/branches/SAMBA_4_0/source&rev=1957&nolog=1

Log:
add cmdline_set_* functions

and let smbclient use the cmdline _* functions

metze

Modified:
   branches/SAMBA_4_0/source/client/client.c
   branches/SAMBA_4_0/source/lib/cmdline/popt_common.c


Changeset:
Modified: branches/SAMBA_4_0/source/client/client.c
===================================================================
--- branches/SAMBA_4_0/source/client/client.c   2004-08-20 13:16:55 UTC (rev 1956)
+++ branches/SAMBA_4_0/source/client/client.c   2004-08-20 13:24:28 UTC (rev 1957)
@@ -36,8 +36,6 @@
 static pstring username;
 static pstring domain;
 static pstring password;
-static BOOL use_kerberos;
-static BOOL got_pass;
 static char *cmdstr = NULL;
 
 static int io_bufsize = 64512;
@@ -2799,18 +2797,11 @@
                return NULL;
        }
 
-       if (!got_pass) {
-               const char *pass = getpass("Password: ");
-               if (pass) {
-                       pstrcpy(password, pass);
-               }
-       }
-
        status = smbcli_session_setup(c, username, password, domain);
        if (NT_STATUS_IS_ERR(status)) {
                d_printf("authenticated session setup failed: %s\n", 
nt_errstr(status));
                /* if a password was not supplied then try again with a null username 
*/
-               if (password[0] || !username[0] || use_kerberos) {
+               if (password[0] || !username[0]) {
                        status = smbcli_session_setup(c, "", "", lp_workgroup());
                }
                if (NT_STATUS_IS_ERR(status)) {
@@ -3064,8 +3055,7 @@
        }
 
        if (poptPeekArg(pc)) { 
-               cmdline_auth_info.got_pass = True;
-               pstrcpy(cmdline_auth_info.password,poptGetArg(pc));  
+               cmdline_set_userpassword(poptGetArg(pc));
        }
 
        /*init_names(); */
@@ -3077,15 +3067,9 @@
 
        poptFreeContext(pc);
 
-       pstrcpy(username, cmdline_auth_info.username);
-       if (cmdline_auth_info.domain[0]) {
-               pstrcpy(domain, cmdline_auth_info.domain);
-       } else {
-               pstrcpy(domain, lp_workgroup());
-       }
-       pstrcpy(password, cmdline_auth_info.password);
-       use_kerberos = cmdline_auth_info.use_kerberos;
-       got_pass = cmdline_auth_info.got_pass;
+       pstrcpy(username, cmdline_get_username());
+       pstrcpy(domain, cmdline_get_userdomain());
+       pstrcpy(password, cmdline_get_userpassword());
 
        DEBUG( 3, ( "Client started (version %s).\n", SAMBA_VERSION_STRING ) );
 

Modified: branches/SAMBA_4_0/source/lib/cmdline/popt_common.c
===================================================================
--- branches/SAMBA_4_0/source/lib/cmdline/popt_common.c 2004-08-20 13:16:55 UTC (rev 
1956)
+++ branches/SAMBA_4_0/source/lib/cmdline/popt_common.c 2004-08-20 13:24:28 UTC (rev 
1957)
@@ -397,11 +397,21 @@
        POPT_TABLEEND
 };
 
+void cmdline_set_username(const char *name)
+{
+       pstrcpy(cmdline_auth_info.username, name);
+}
+
 const char *cmdline_get_username(void)
 {
        return cmdline_auth_info.username;
 }
 
+void cmdline_set_userdomain(const char *domain)
+{
+       pstrcpy(cmdline_auth_info.domain, domain);
+}
+
 const char *cmdline_get_userdomain(void)
 {
        if (cmdline_auth_info.domain[0]) {
@@ -431,3 +441,19 @@
 
        return getpass(prompt);
 }
+
+void cmdline_set_userpassword(const char *pass)
+{
+       cmdline_auth_info.got_pass = True;
+       pstrcpy(cmdline_auth_info.password, pass);
+}
+
+void cmdline_set_use_kerberos(BOOL use_kerberos)
+{
+       cmdline_auth_info.use_kerberos = use_kerberos;
+}
+
+BOOL cmdline_get_use_kerberos(void)
+{
+       return cmdline_auth_info.use_kerberos;
+}

Reply via email to