svn commit: samba r14153 - branches/SAMBA_3_0/source/utils trunk/source/utils

[jmcd]

Author: jmcd
Date: 2006-03-10 14:17:44 +0000 (Fri, 10 Mar 2006)
New Revision: 14153

WebSVN: 
http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14153

Log:
Fix coverity #116: free storage alloc'ed by sstring_sub()

Modified:
   branches/SAMBA_3_0/source/utils/net_rpc_samsync.c
   trunk/source/utils/net_rpc_samsync.c


Changeset:
Modified: branches/SAMBA_3_0/source/utils/net_rpc_samsync.c
===================================================================
--- branches/SAMBA_3_0/source/utils/net_rpc_samsync.c   2006-03-10 14:14:23 UTC 
(rev 14152)
+++ branches/SAMBA_3_0/source/utils/net_rpc_samsync.c   2006-03-10 14:17:44 UTC 
(rev 14153)
@@ -1412,6 +1412,7 @@
            strcmp(groupname, "Print Operators") == 0 ||
            strcmp(groupname, "Backup Operators") == 0 ||
            strcmp(groupname, "Replicators") == 0) {
+               SAFE_FREE(group_attr);
                return NT_STATUS_OK;
        } else {
                /* Increment the gid for the new group */
@@ -1441,6 +1442,7 @@
        fprintf(add_fd, "\n");
        fflush(add_fd);
 
+       SAFE_FREE(group_attr);
        /* Return */
        return NT_STATUS_OK;
 }

Modified: trunk/source/utils/net_rpc_samsync.c
===================================================================
--- trunk/source/utils/net_rpc_samsync.c        2006-03-10 14:14:23 UTC (rev 
14152)
+++ trunk/source/utils/net_rpc_samsync.c        2006-03-10 14:17:44 UTC (rev 
14153)
@@ -1412,6 +1412,7 @@
            strcmp(groupname, "Print Operators") == 0 ||
            strcmp(groupname, "Backup Operators") == 0 ||
            strcmp(groupname, "Replicators") == 0) {
+               SAFE_FREE(group_attr);
                return NT_STATUS_OK;
        } else {
                /* Increment the gid for the new group */
@@ -1441,6 +1442,7 @@
        fprintf(add_fd, "\n");
        fflush(add_fd);
 
+       SAFE_FREE(group_attr);
        /* Return */
        return NT_STATUS_OK;
 }