Author: vlendec Date: 2006-03-12 17:44:00 +0000 (Sun, 12 Mar 2006) New Revision: 14245
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14245 Log: We've dereferenced argv before, no point in checking. Fix Coverity bug # 144. Volker Modified: branches/SAMBA_3_0/source/rpcclient/rpcclient.c trunk/source/rpcclient/rpcclient.c Changeset: Modified: branches/SAMBA_3_0/source/rpcclient/rpcclient.c =================================================================== --- branches/SAMBA_3_0/source/rpcclient/rpcclient.c 2006-03-12 17:29:42 UTC (rev 14244) +++ branches/SAMBA_3_0/source/rpcclient/rpcclient.c 2006-03-12 17:44:00 UTC (rev 14245) @@ -663,13 +663,11 @@ } */ - if (argv) { - /* NOTE: popt allocates the whole argv, including the - * strings, as a single block. So a single free is - * enough to release it -- we don't free the - * individual strings. rtfm. */ - free(argv); - } + /* NOTE: popt allocates the whole argv, including the + * strings, as a single block. So a single free is + * enough to release it -- we don't free the + * individual strings. rtfm. */ + free(argv); return result; } Modified: trunk/source/rpcclient/rpcclient.c =================================================================== --- trunk/source/rpcclient/rpcclient.c 2006-03-12 17:29:42 UTC (rev 14244) +++ trunk/source/rpcclient/rpcclient.c 2006-03-12 17:44:00 UTC (rev 14245) @@ -665,13 +665,11 @@ } */ - if (argv) { - /* NOTE: popt allocates the whole argv, including the - * strings, as a single block. So a single free is - * enough to release it -- we don't free the - * individual strings. rtfm. */ - free(argv); - } + /* NOTE: popt allocates the whole argv, including the + * strings, as a single block. So a single free is + * enough to release it -- we don't free the + * individual strings. rtfm. */ + free(argv); return result; }
