Author: jra Date: 2006-03-27 02:45:11 +0000 (Mon, 27 Mar 2006) New Revision: 14741
WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=14741 Log: Coverity never sleeps :-). Fix uninitialized variable use (CID #228). Jeremy. Modified: trunk/source/libsmb/smb_signing.c Changeset: Modified: trunk/source/libsmb/smb_signing.c =================================================================== --- trunk/source/libsmb/smb_signing.c 2006-03-26 12:57:50 UTC (rev 14740) +++ trunk/source/libsmb/smb_signing.c 2006-03-27 02:45:11 UTC (rev 14741) @@ -343,7 +343,6 @@ { BOOL good; uint32 reply_seq_number; - uint32 saved_seq; unsigned char calc_md5_mac[16]; unsigned char *server_sent_mac; @@ -377,7 +376,7 @@ simple_packet_signature(data, (const unsigned char *)inbuf, reply_seq_number+i, calc_md5_mac); if (memcmp(server_sent_mac, calc_md5_mac, 8) == 0) { DEBUG(0,("client_check_incoming_message: out of seq. seq num %u matches. \ -We were expecting seq %u\n", reply_seq_number, saved_seq )); +We were expecting seq %u\n", reply_seq_number+i, reply_seq_number )); break; } } @@ -388,7 +387,7 @@ DEBUG(10, ("client_check_incoming_message: seq %u: got good SMB signature of\n", (unsigned int)reply_seq_number)); dump_data(10, (const char *)server_sent_mac, 8); } - return signing_good(inbuf, si, good, saved_seq, must_be_ok); + return signing_good(inbuf, si, good, reply_seq_number, must_be_ok); } /***********************************************************
